Skip to content

fix(core/github): edDraftURI opt-out and custom newIssuesURL#5246

Open
marcoscaceres wants to merge 2 commits intomainfrom
fix/5103-eddrafturi
Open

fix(core/github): edDraftURI opt-out and custom newIssuesURL#5246
marcoscaceres wants to merge 2 commits intomainfrom
fix/5103-eddrafturi

Conversation

@marcoscaceres
Copy link
Copy Markdown
Contributor

@marcoscaceres marcoscaceres commented May 4, 2026

Closes #5103
Closes #4317

@marcoscaceres marcoscaceres requested a review from Copilot May 4, 2026 01:20
Copilot AI reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub integration in ReSpec’s core config normalization so specs can customize the “new issue” destination and aims to support opting out of the GitHub-derived edDraftURI. It also extends the GitHub module’s localized strings and adds/updates tests around the new config behavior.

Changes:

  • Add support for github.newIssuesURL and use it when generating GitHub feedback links.
  • Adjust core/github handling around edDraftURI generation when the config explicitly provides that field.
  • Add GitHub spec tests for edDraftURI opt-out cases and custom newIssuesURL, plus French localization strings in core/github.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/core/github.js Adds French strings, introduces custom newIssuesURL parsing/validation, and changes edDraftURI defaulting logic.
tests/spec/core/github-spec.js Adds tests for explicit edDraftURI values and normalization of custom newIssuesURL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/core/github.js
Comment thread tests/spec/core/github-spec.js
Comment thread src/core/github.js
@marcoscaceres
Copy link
Copy Markdown
Contributor Author

marcoscaceres commented May 4, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

@marcoscaceres
test(core/github): add DOM assertion for custom newIssuesURL rendered…
ce9b996 
… link

Agent-Logs-Url: https://github.com/speced/respec/sessions/20f04c30-6520-406b-b673-555dabf64b8b

Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

All three reviewer concerns have been addressed:

  1. HTTPS-only check on newIssuesURL (comment on lines 109-120): No change needed — the intentionally broad HTTPS check is correct for monorepo label-filtered query scenarios, as you explained.

  2. DOM assertion for newIssuesURL test (comment on lines 108-123): Fixed in ce9b996 — added excludeGithubLinks: false to the test config and added a DOM assertion that the rendered "File an issue" link uses the custom URL.

  3. edDraftURI opt-out via hasOwnProperty (comment on lines 204-205): No change needed — the hasOwnProperty("edDraftURI") guard correctly skips auto-generation when the author explicitly sets the value (including null or ""), and the two new tests verify both paths.

@marcoscaceres
Copy link
Copy Markdown
Contributor Author

marcoscaceres commented May 8, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

All three reviewer concerns are fully addressed:

  1. HTTPS-only check on newIssuesURL — intentionally broad (no change needed, per your earlier explanation about monorepo label-filtered query scenarios).

  2. DOM assertion for newIssuesURL test — fixed in ce9b996: added excludeGithubLinks: false so links render, then asserts the "File an issue" <dd> link uses the custom URL.

  3. edDraftURI opt-out via hasOwnProperty — correctly implemented; no change needed.

@marcoscaceres marcoscaceres marked this pull request as ready for review May 9, 2026 02:40
@marcoscaceres marcoscaceres requested review from sidvishnoi and removed request for sidvishnoi May 9, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

Copilot code review Copilot Copilot left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using github while disabling edDraftURI Custom URL for issues

3 participants

@marcoscaceres